Json schema kafka quickstart #1414
Conversation
This comment has been minimized.
This comment has been minimized.
carlesarnal
force-pushed
the
json-schema-kafka-quickstart
branch
from
1ad6e60 to
bcf109a
Compare
This comment has been minimized.
This comment has been minimized.
carlesarnal
force-pushed
the
json-schema-kafka-quickstart
branch
from
bcf109a to
fdc8f20
Compare
This comment has been minimized.
This comment has been minimized.
carlesarnal
force-pushed
the
json-schema-kafka-quickstart
branch
from
fdc8f20 to
1688afa
Compare
carlesarnal
force-pushed
the
json-schema-kafka-quickstart
branch
from
1688afa to
eb28de3
Compare
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
|
@cescoffier @ozangunalp could you have a look at this one? It looks interesting and maybe something we should document in the guides, if we get it in? |
cescoffier
left a comment
cescoffier
left a comment
There was a problem hiding this comment.
Looks good. I'm wondering if some properties can be deduced automatically.
|
|
||
| mp.messaging.outgoing.movies.apicurio.registry.auto-register=true | ||
| mp.messaging.outgoing.movies.apicurio.registry.artifact.schema.location=json-schema.json | ||
| mp.messaging.outgoing.movies.value.serializer=io.apicurio.registry.serde.jsonschema.JsonSchemaKafkaSerializer |
There was a problem hiding this comment.
Kind of sad we can't detect these automatically.
@ozangunalp WDYT?
|
The guide already exists: https://quarkus.io/guides/kafka-schema-registry-json-schema |
|
Was the provided schema expected to validate the json? The schema contains an error, (I guess explicitly) but I don't see that produce is rejected with schema validation error. It needs to set "required" properties in order to validate the content. @cescoffier yes, I think we can emit default values for serde when the property |
| mp.messaging.outgoing.movies.apicurio.registry.auto-register=true | ||
| mp.messaging.outgoing.movies.apicurio.registry.artifact.schema.location=json-schema.json | ||
| mp.messaging.outgoing.movies.value.serializer=io.apicurio.registry.serde.jsonschema.JsonSchemaKafkaSerializer | ||
| mp.messaging.outgoing.movies.value.deserializer=io.apicurio.registry.serde.jsonschema.JsonSchemaKafkaDeserializer |
4 participants
Check list:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.mdOpening as a replacement of #1361 targeting development